fix: CI/CD 이미지명, 경로, health check 엔드포인트 수정#54
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces production-ready configurations, including a new docker-compose-prod.yml with Fluent Bit logging and a PostgreSQL service, and adds Spring Boot Actuator for monitoring. Several critical issues were identified: the hibernate.ddl-auto setting in the production profile was changed to update, which poses a high risk of data loss; the Dockerfile health check uses an incorrect path and an impractical 24-hour interval; the development compose file points to a backup Dockerfile; and the production image uses the latest tag, compromising deployment stability.
| jpa: | ||
| hibernate: | ||
| ddl-auto: validate | ||
| ddl-auto: update |
Comment on lines
+36
to
+37
| HEALTHCHECK --interval=24h --timeout=10s --start-period=40s --retries=3 \ | ||
| CMD curl -sf http://localhost:7300/health || exit 1 |
There was a problem hiding this comment.
HEALTHCHECK 설정에 두 가지 개선 사항이 있습니다.
- 경로 불일치:
spring-boot-starter-actuator를 의존성에 추가하셨는데, 기본 헬스체크 경로는/actuator/health입니다. 현재/health로 설정되어 있어 Docker daemon이 컨테이너를unhealthy상태로 판단할 수 있습니다. - 주기(Interval) 설정:
interval=24h는 장애 감지 주기가 너무 깁니다. 컨테이너 상태를 적절히 모니터링하기 위해 보통30s정도로 설정하는 것을 권장합니다.
HEALTHCHECK --interval=30s --timeout=10s --start-period=40s --retries=3 \
CMD curl -sf http://localhost:7300/actuator/health || exit 1
| build: | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| dockerfile: Dockerfile.prev |
| restart: unless-stopped | ||
|
|
||
| app: | ||
| image: ghcr.io/wisoft-prepair/backend-java:latest |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용 (Description)
CI/CD 이미지명, 경로, health check 엔드포인트 수정
🔄 변경 유형 (Type of Change)
✅ 체크리스트 (Checklist)